Refactoring#1797
Refactoring#1797AlexanderStocks wants to merge 3 commits intoJSQLParser:masterfrom AlexanderStocks:refactoringJanitor
Conversation
|
Greetings, Alexander. Thank you very much for your contribution and welcome to JSQLParser. This is all great stuff, but unfortunately you were unlucky with the timing:
Again, thank you very much for your work. Do have a look at the massive pending changes and then we can pick it up from here. Do let me know how I can assist you to achieve the best out of both worlds. Please provide 1 PR only containing "Removed Duplicates", then one only for "Nested If statements" and only then Reformatting makes sense. |
|
Btw, if you are really keen to format something, then it should be the JavaCC Grammar, which is an utter mess. Since there is no beautifier for JavaCC Grammars (I have had no time for that yet), it's an open field for making merit. |
| @@ -72,11 +74,7 @@ public String toString() { | |||
| if (indexExpression != null) { | |||
| return objExpression.toString() + "[" + indexExpression.toString() + "]"; | |||
| } else { | |||
There was a problem hiding this comment.
This is a perfect example for a reject: The Format may be Google style compliant, but it is harder to read how/why the string is composed. The logic is lost.
2 participants
Description:
As part of my dissertation project, I've undertaken a sequence of automated refactorings and applied formatting with the goal to improve the quality of the codebase in this repository:
Reformat: Utilizing Google's Java Code Style guidelines, I have reformatted 534 files to enhance readability and ensure compliance with widely accepted style norms.
CollapseNestedIfStatements: I have executed the CollapseNestedIfStatements refactoring on 2 files. This refactoring effort is aimed at simplifying the logic of the code and making it more readable.
RemoveDuplication: I have executed the RemoveDuplication refactoring on 10 file, aiming to streamline the codebase by eliminating redundant code blocks.
These changes were executed using the Refactoring Janitor tool.
Request for Feedback:
As this initiative is part of my dissertation project, your comments, feedback, or suggestions about the changes I've made would be immensely valuable. Your insights will greatly contribute to my research and learning.